Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add packagePaths to options when calling ElectronInstaller.movePackage() #36

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

malept
Copy link
Member

@malept malept commented Jun 12, 2019

Electron Forge needs to know what the final paths of the distributables that electron-installer-* generate, so it can do things like publish to service X. Since -debian and -redhat have options that allow a user to customize what the name is, the installer modules need to pass back the resulting package file paths.

@malept malept requested a review from fcastilloec June 12, 2019 00:40
@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #36   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         197    198    +1     
=====================================
+ Hits          197    198    +1
Impacted Files Coverage Δ
src/installer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d61c6e...b8a1e16. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant